FEATURE: New API hook to allow for client side upload transforms (PR #12990)

GitHub

We should add a cleanUp that we can call between tests. Otherwise the contents of those arrays might stick around.

Check FEATURE: New API hook to allow for client side upload transforms by xfalcox · Pull Request #12990 · discourse/discourse · GitHub. Is that what you had in mind?

Yes, but they should be called after test runs.

What tests? Do you mean globally like in discourse/setup-tests.js at master · discourse/discourse · GitHub ?

This pull request introduces 4 alerts when merging b2147c936d435c3ea1ba426a4e02746b0c7c58cd into 7a0e5c8cb945f2c2aafa314ff71ef4dd2d87899c - view on LGTM.com

new alerts:

  • 4 for Assignment to constant

Maybe I should push this cleanUp stuff in another PR

Usually I put them here, but another PR is fine:

This doesn’t feel right to me. $.blueimp is a vendor concern that our Discourse code base should not have to be aware of.

This doesn’t feel right to me. $.blueimp is a vendor concern that our Discourse code base should not have to be aware of.

That is their only documented way of registering processActions callbacks. That being said, I’m working on merging the theme-component that uses this into core and will look into removing this!