- Adds a new setting and for tl2 editing posts (30 days same as old value)
- Sets the tl0/tl1 editing period as 1 day
You’ve signed the CLA, rimian. Thank you! This pull request is ready for review.
Is there a relevant meta discussion for this change? I’m looking for some context here.
Sorry, I am not sure where to reference things and where to put the context just yet. I’ll clear that up before my next PR
Yeah a quick link in the PR is always a good idea cause there are many of us, but really not a huge deal.
can we avoid shared_examples, I think it just confuses stuff. makes the specs a bit harder to follow.
update_columns should do the trick it avoids a bunch of callbacks making the spec a tiny bit faster.
Overall the change looks good to me! minor changes to the specs and we should be good to merge.
This pull request has been mentioned on Discourse Meta. There might be relevant details there: