FEATURE: Parse images in email signatures (PR #10137)

GitHub

Why was this change required?

This method is weird. It’s returning options which looks like is never used and also updates “in-place” the options argument?

I just tried this one again and it looks like it was a problem with the example I used for testing. In my development environment, that email was parsed differently by Nokogiri::HTML and Nokogiri::HTML5. The change is no longer needed. :blush:

You are right, I was torn between the two and finally went with the in-place changes and left the return code too.