This removes lodash usage. Most uses are not useful but some might be worth keeping around. In that case it should be a model.
Careful on that one:
Reading this, it seems like you are aware of the difference between the two isEmpty
the only thing first does is working with null/undefined.
_.first(null) // undefined
So I guess codepaths replacing _.first should ensure the object is not null/undefined.
Probably with a deprecation.
The title of this pull request changed from “Move lodash to model or remove it” to "FEATURE: Remove lodash usage and deprecate it.
I believe I accounted for this. All tests are passing.
@xfalcox yes I am aware. The PR was still in draft and I hadn’t finished at that point.
It now removes all lodash usage in our codebase and deprecates it for plugins/themes to continue working until we update their code too. I’ve slated it for removal in 2.7.
Rspec failure seems unrelated.