FEATURE: Special call-out for new / returning posters. (PR #7115)

[udan11]

GitHub

[discoursebot]

You’ve signed the CLA, udan11. Thank you! This pull request is ready for review.

[discoursebot]

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/special-callout-for-first-time-posters/106481/31

[SamSaffron]

Edge case:

• user creates post … gets notice
• admin deletes post
• user creates another post… gets notice
• admin undeletes old post, now 2 posts have a notice

Simplest workaround is to blow up the notice on undelete, trickier one is just to remove other dupe notices on undelete.

[eviltrout]

lib/post_creator.rb

@@ -508,6 +509,24 @@ def update_user_counts
     @user.update_attributes(last_posted_at: @post.created_at)
   end
 
+  def create_post_notice
+    last_post_time = Post.where(user_id: @user.id)
+      .where('created_at < ?', 1.day.ago)
+      .order(:created_at)
+      .limit(1)
+      .pluck(:created_at)
+      .first
+
+    if !last_post_time

   unless last_post_time

[ZogStriP]

lib/post_creator.rb

@@ -508,6 +509,24 @@ def update_user_counts
     @user.update_attributes(last_posted_at: @post.created_at)
   end
 
+  def create_post_notice
+    last_post_time = Post.where(user_id: @user.id)

Why check for posts older than 1 day? Also, the order doesn’t seem right

last_post_time = Post.where(user_id: @user.id)
  .order(created_at: :desc)
  .limit(1)
  .pluck(:created_at)
  .first

[ZogStriP]

The order in the query for last_post_time should be descending.