FIX: Ascending/descending sorting in the group membership requests page

FIX: Ascending/descending sorting in the group membership requests page

The GroupsController#members endpoint accepts a desc parameter to determine how members are sorted, but it’s been deprecated in favor of a boolean asc parameter. However, in the frontend, specifically the group membership requests page was not updated entirely to use the asc param and it still passes a desc param when changing how group requests are sorted.

This commit updates the group-requests Ember controller so it passes a boolean asc param and removes all references of desc. The controller view/template has already been updated to use asc:

diff --git a/app/assets/javascripts/discourse/app/controllers/group-requests.js b/app/assets/javascripts/discourse/app/controllers/group-requests.js
index 73da360..9cb4dcf 100644
--- a/app/assets/javascripts/discourse/app/controllers/group-requests.js
+++ b/app/assets/javascripts/discourse/app/controllers/group-requests.js
@@ -7,10 +7,10 @@ import { popupAjaxError } from "discourse/lib/ajax-error";
 export default Controller.extend({
   application: controller(),
-  queryParams: ["order", "desc", "filter"],
+  queryParams: ["order", "asc", "filter"],
   order: "",
-  desc: null,
+  asc: null,
   filter: null,
   filterInput: null,
@@ -27,7 +27,7 @@ export default Controller.extend({
-  @observes("order", "desc", "filter")
+  @observes("order", "asc", "filter")
   _filtersChanged() {
@@ -57,9 +57,9 @@ export default Controller.extend({
-  @discourseComputed("order", "desc", "filter")
-  memberParams(order, desc, filter) {
-    return { order, desc, filter };
+  @discourseComputed("order", "asc", "filter")
+  memberParams(order, asc, filter) {
+    return { order, asc, filter };

GitHub sha: 810892139b2d27fb87a823180bb092db6bdfad8d

This commit appears in #13761 which was approved by ZogStriP. It was merged by OsamaSayegh.