FIX: Change bookmarks-with-reminders URL back to bookmarks for user activity (PR #9566)

  • Bookmarks with reminders is a core feature now, no need to have a separate URL
  • Keep around the old /u/:username/activity/bookmarks-with-reminders route for backwards compat in Ember but just redirect to user activity bookmarks.

GitHub

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542/121

  redirect() {

This is technically a breaking change. I assume no plugins / themes had time to modify this route so that’s good - but the narrative post could have created posts with links that now 404?

Can we redirect those links to the new URL?

@eviltrout the new route is still there and redirects to /bookmarks, see @jjaffeux’s review comment. Will keep it around for a while before nuking it.

This pull request has been mentioned on Discourse Meta. There might be relevant details there: