FIX: correctly shows no bookmark message (PR #9548)

GitHub

I find this kind of operation is much better suited for a model than a controller. Is there a reason we can’t do the transformation in the model?

1 Like

Agreed, I might merge it like this and refactor with martin in another commit if that’s ok though.

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542/120

Thanks @jjaffeux! :+1:

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/improved-bookmarks-with-reminders/144542/121

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/reporting-few-issues-with-bookmarks/149283/4