FIX: Create CORS rule on S3 only before a backup upload

FIX: Create CORS rule on S3 only before a backup upload
diff --git a/lib/backup_restore/s3_backup_store.rb b/lib/backup_restore/s3_backup_store.rb
index 2fae590..813e1cc 100644
--- a/lib/backup_restore/s3_backup_store.rb
+++ b/lib/backup_restore/s3_backup_store.rb
@@ -44,6 +44,7 @@ module BackupRestore
       obj = @s3_helper.object(filename)
       raise BackupFileExists.new if obj.exists?
 
+      ensure_cors!
       presigned_url(obj, :put, UPLOAD_URL_EXPIRES_AFTER_SECONDS)
     end
 
@@ -74,7 +75,6 @@ module BackupRestore
     end
 
     def presigned_url(obj, method, expires_in_seconds)
-      ensure_cors!
       obj.presigned_url(method, expires_in: expires_in_seconds)
     end

GitHub
sha: 7e1f20b0

1 Like

This commit has been mentioned on Discourse Meta. There might be relevant details there: