FIX: delete orphan post revisions (PR #12502)

I was adding specs to ensure that post actions and uploads are removed for permanently deleted posts.

I noticed that post revisions were not permanently destroyed. I added a migration to fix old data.

GitHub

    @post.revisions.each(&:destroy!)

We’re not using the resulting true-filled array :smiley:

Should this be a migration or a post_migration? :thinking:

The app doesn’t depend on this change and it’s potentially a slow SQL, so I’d move it into a post migration.

Looks good :+1:

@SamSaffron would disable_ddl_transaction! be in any way helpful (or necessary?) in simple single-query cases like this?

For this trivial case where there is only 1 statement, no it should not make any difference