FIX: Deprecated overwriting of computed property

FIX: Deprecated overwriting of computed property

We can set hide to true instead of overwriting the property on dismiss.

diff --git a/app/assets/javascripts/discourse/app/components/discourse-banner.js b/app/assets/javascripts/discourse/app/components/discourse-banner.js
index e9149bb..baf54cf 100644
--- a/app/assets/javascripts/discourse/app/components/discourse-banner.js
+++ b/app/assets/javascripts/discourse/app/components/discourse-banner.js
@@ -2,6 +2,8 @@ import discourseComputed from "discourse-common/utils/decorators";
 import Component from "@ember/component";
 
 export default Component.extend({
+  hide: false,
+
   @discourseComputed("banner.html")
   content(bannerHtml) {
     const $div = $("<div>");
@@ -30,7 +32,7 @@ export default Component.extend({
       if (this.user) {
         this.user.dismissBanner(this.get("banner.key"));
       } else {
-        this.set("visible", false);
+        this.set("hide", true);
         this.keyValueStore.set({
           key: "dismissed_banner_key",
           value: this.get("banner.key"),

GitHub sha: 070fe7f4

This commit appears in #10809 which was approved by CvX and ZogStriP. It was merged by eviltrout.