FIX: do not attempt to migrate pre-existing uploads

FIX: do not attempt to migrate pre-existing uploads

This makes this job re-runnable just in case cause it will skip creation of new uploads if an upload already exists

diff --git a/app/jobs/onceoff/migrate_url_site_settings.rb b/app/jobs/onceoff/migrate_url_site_settings.rb
index 63df91a..4ddb2f3 100644
--- a/app/jobs/onceoff/migrate_url_site_settings.rb
+++ b/app/jobs/onceoff/migrate_url_site_settings.rb
@@ -17,6 +17,12 @@ module Jobs
 
     def execute_onceoff(args)
       SETTINGS.each do |old_setting, new_setting|
+
+        if upload_id = SiteSetting.get(new_setting)
+          logger.warn("Skipping migration of the Site Setting #{new_setting} to url cause upload #{upload_id} already exists for it")
+          next
+        end
+
         old_url = DB.query_single(
           "SELECT value FROM site_settings WHERE name = '#{old_setting}'"
         ).first

GitHub sha: 667b9801

1 Like

DEV: only skip migration if a non seeded upload exists