FIX: Do not display the color scheme ID in interface dropdown (PR #14066)

When a theme’s default color scheme is not marked as user selectable, we were outputting the numeric ID in the UI. This outputs “Theme default” instead.

GitHub

Can’t we fix this server side ?

you have a helper for rows: dropdownObject.rows().length

I would recommend to hold the dropdown object in a var so you just reuse it

do we need this get ?

Can’t we fix this server side ?

Yes, we can fix this server-side, I tried that initially but doing so added add one more query when bootstrapping (to pull the default theme’s color scheme ID), and given that’s a critical path, I opted to fix it client-side using the already available data under user_themes.