FIX: do not parameterize tag_id (#9839)

FIX: do not parameterize tag_id (#9839)

Parameterizing tag_id was breaking tags with non-ascii characters or emoji.

Bug report: https://meta.discourse.org/t/unable-to-see-pm-lists-for-non-ascii-tag/151723/4

diff --git a/lib/topic_query_params.rb b/lib/topic_query_params.rb
index e1bb23c..bab3013 100644
--- a/lib/topic_query_params.rb
+++ b/lib/topic_query_params.rb
@@ -3,7 +3,7 @@
 module TopicQueryParams
   def build_topic_list_options
     options = {}
-    params[:tags] = [params[:tag_id].parameterize] if params[:tag_id].present? && guardian.can_tag_pms?
+    params[:tags] = [params[:tag_id]] if params[:tag_id].present? && guardian.can_tag_pms?
 
     TopicQuery.public_valid_options.each do |key|
       if params.key?(key)

GitHub sha: 4a533ec5

This commit appears in #9839 which was merged by techAPJ.

I feel like this should have a test.

1 Like

Added spec in DEV: add spec for tag with unicode name · discourse/discourse@61d8955 · GitHub.

1 Like