FIX: do not send welcome message to staged users

FIX: do not send welcome message to staged users

diff --git a/plugins/discourse-narrative-bot/plugin.rb b/plugins/discourse-narrative-bot/plugin.rb
index b51e318..e44a8ae 100644
--- a/plugins/discourse-narrative-bot/plugin.rb
+++ b/plugins/discourse-narrative-bot/plugin.rb
@@ -119,7 +119,7 @@ after_initialize do
   end
 
   self.add_model_callback(User, :after_commit, on: :create) do
-    if SiteSetting.discourse_narrative_bot_welcome_post_delay == 0
+    if SiteSetting.discourse_narrative_bot_welcome_post_delay == 0 && !self.staged
       self.enqueue_bot_welcome_post
     end
   end
diff --git a/plugins/discourse-narrative-bot/spec/requests/discobot_welcome_post_spec.rb b/plugins/discourse-narrative-bot/spec/requests/discobot_welcome_post_spec.rb
index f9087b7..48113a4 100644
--- a/plugins/discourse-narrative-bot/spec/requests/discobot_welcome_post_spec.rb
+++ b/plugins/discourse-narrative-bot/spec/requests/discobot_welcome_post_spec.rb
@@ -43,6 +43,17 @@ describe "Discobot welcome post" do
         expect(Jobs::NarrativeInit.jobs.first["args"].first["user_id"]).to eq(User.last.id)
       end
     end
+  end
+
+  context 'when user is staged' do
+    let(:staged_user) { Fabricate(:user, staged: true) }
+
+    before do
+      SiteSetting.discourse_narrative_bot_welcome_post_type = 'welcome_message'
+    end
 
+    it 'should not send welcome message' do
+      expect { staged_user }.to_not change { Jobs::SendDefaultWelcomeMessage.jobs.count }
+    end
   end
 end

GitHub sha: 3c5fbd3c

2 Likes

This commit has been mentioned on Discourse Meta. There might be relevant details there: