FIX: Docking mixin was not cleaning up timers (PR #12638)

[eviltrout]

I noticed this while trying to debug slow performing ember tests. Our docking mixin sometimes sets timers but never cancels them when removed. I’m not sure of any errors this causes but we should be tidying up whenever the component is removed.

GitHub

[CvX]

app/assets/javascripts/discourse/app/mixins/docking.js

@@ -12,11 +12,13 @@ const helper = {
 
 export default Mixin.create({
   queueDockCheck: null,
+  _initialEvent: null,
+  _queuedEvent: null,

Those are timers, not events.

[eviltrout]

Argh, you’re right. Updated.

[CvX]

app/assets/javascripts/discourse/app/mixins/docking.js

@@ -12,11 +12,13 @@ const helper = {
 
 export default Mixin.create({
   queueDockCheck: null,
+  _initialTimer: null,
+  _queuedEvent: null,

:trollface:

[eviltrout]

oh my god I have no idea what’s wrong with me.