FIX: dont error when bookmark topic is nil (#10555)

FIX: dont error when bookmark topic is nil (#10555)

diff --git a/lib/bookmark_reminder_notification_handler.rb b/lib/bookmark_reminder_notification_handler.rb
index e01f2dc..e0c105c 100644
--- a/lib/bookmark_reminder_notification_handler.rb
+++ b/lib/bookmark_reminder_notification_handler.rb
@@ -7,6 +7,7 @@ class BookmarkReminderNotificationHandler
       if bookmark.post.blank? || bookmark.post.deleted_at.present?
         return clear_reminder(bookmark)
       end
+      return unless bookmark.topic
 
       create_notification(bookmark)
 
diff --git a/spec/jobs/bookmark_reminder_notifications_spec.rb b/spec/jobs/bookmark_reminder_notifications_spec.rb
index 25379d0..852aaba 100644
--- a/spec/jobs/bookmark_reminder_notifications_spec.rb
+++ b/spec/jobs/bookmark_reminder_notifications_spec.rb
@@ -59,4 +59,11 @@ RSpec.describe Jobs::BookmarkReminderNotifications do
       end
     end
   end
+
+  it 'will not send notification when topic is not available' do
+    bookmark1.topic.destroy
+    bookmark2.topic.destroy
+    bookmark3.topic.destroy
+    expect { subject.execute }.not_to change { Notification.where(notification_type: Notification.types[:bookmark_reminder]).count }
+  end
 end

GitHub sha: 94152e46

This commit appears in #10555 which was approved by eviltrout. It was merged by lis2.