FIX: don't show create topic suggestion to users who can't

FIX: don’t show create topic suggestion to users who can’t

Users with TL below the “min trust to create topic” setting used to see a prompt to create new topics in the footer message below the topic list. Those topics would never be submitted because those users don’t meet the TL requirements to create a new topic (based on that site setting). This PR removes that prompt for those users.

diff --git a/app/assets/javascripts/discourse/app/routes/build-category-route.js b/app/assets/javascripts/discourse/app/routes/build-category-route.js
index 58e5584..aa6da58 100644
--- a/app/assets/javascripts/discourse/app/routes/build-category-route.js
+++ b/app/assets/javascripts/discourse/app/routes/build-category-route.js
@@ -177,7 +177,7 @@ export default (filterArg, params) => {
         category = model.category,
         canCreateTopic = topics.get("can_create_topic"),
         canCreateTopicOnCategory =
-          category.get("permission") === PermissionType.FULL,
+          canCreateTopic && category.get("permission") === PermissionType.FULL,
         filter = this.filter(category);
 
       this.controllerFor("navigation/category").setProperties({

GitHub sha: 415c1bb9

This commit has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/is-it-possible-to-remove-why-not-create-a-topic-link-for-users-who-dont-have-permission-to-create-posts/154297/8