You’ve signed the CLA, shivpkumar. Thank you! This pull request is ready for review.
Excellent thanks Shiv! On Aug 14, 2014 1:30 PM, “Shiv Kumar” email@example.com wrote:
You can merge this Pull Request by running
git pull https://github.com/shivpkumar/discourse patch-1
Or view, comment on, or merge it at:
https://github.com/discourse/discourse/pull/2657 Commit Summary
- [FIX] Don’t show Sign Up button if local logins are disabled
— Reply to this email directly or view it on GitHub https://github.com/discourse/discourse/pull/2657.
Actually this morning I modified it so that the “button providers” for signing in are shown on the create account modal and the form isn’t. A site without logins can safely have two buttons.
If the whole point of having two buttons is to make it easier for people who don’t have a login to not be confused, maybe we shouldn’t accept this one?
So why is it that on discuss.newrelic.com, I have
enable local logins unchecked, but the full form still shows? Shouldn’t the form be gone in that case?
Are you on the latest code? I deployed that fix this morning.
Ah it’s because we’re overriding the Create Account template. We handle both log in and sign up in the Login template, so we don’t need the Sign Up button. For now, I’m just using CSS to hide the Sign Up button altogether. Feel free to close this PR.
I’ll close this for now. We’ll keep the fix around in case we change our minds, but right now the feedback seems to be that having two buttons is less confusing to users than one