FIX: ensures successive topic hydrates doesn't override category (#12865)

FIX: ensures successive topic hydrates doesn’t override category (#12865)

This bug has first been seen when loading similar topics, minimum repro:

  • Have a topic named “Something Foo Bar” with a category.

  • Call this in console:

Discourse.currentUser.store.find("similar-topic", { title: "Something foo bar", raw: "" })
  • Navigate to latest (no full refresh)

  • The category from the topic should have disappeared

diff --git a/app/assets/javascripts/discourse/app/models/topic.js b/app/assets/javascripts/discourse/app/models/topic.js
index 5298b2b..6dc8a68 100644
--- a/app/assets/javascripts/discourse/app/models/topic.js
+++ b/app/assets/javascripts/discourse/app/models/topic.js
@@ -614,6 +614,12 @@ Topic.reopenClass({
     MUTED: 0,
   },
 
+  munge(json) {
+    // ensure we are not overriding category computed property
+    delete json.category;
+    return json;
+  },
+
   createActionSummary(result) {
     if (result.actions_summary) {
       const lookup = EmberObject.create();

GitHub sha: 71fd01c8

This commit appears in #12865 which was approved by CvX and eviltrout. It was merged by jjaffeux.