FIX: Error when SMTP enabled in PostAlerter with no incoming email (PR #14981)

When FIX: Use correct group out of multiple for SMTP sender (#14957) · discourse/discourse@3103501 · GitHub was done it failed to take into account the case where the smtp_enabled site setting was true, but the topic had no allowed groups / no incoming email record, which caused errors for topics even with nothing to do with group SMTP.

GitHub

technically in a weird world post.topic can be nil…

This is already handled further up discourse/post_alerter.rb at 10914a4ffde995098d6c313b9110e3ba6fe3d579 · discourse/discourse · GitHub

1 Like