FIX: if favicon is missing due to bad url we would return a 500 on favicons

FIX: if favicon is missing due to bad url we would return a 500 on favicons

This ensures that the error logging does not corrupt the cache

diff --git a/app/controllers/static_controller.rb b/app/controllers/static_controller.rb
index 7d6d37d..7c69db5 100644
--- a/app/controllers/static_controller.rb
+++ b/app/controllers/static_controller.rb
@@ -143,6 +143,7 @@ class StaticController < ApplicationController
           rescue => e
             AdminDashboardData.add_problem_message('dashboard.bad_favicon_url', 1800)
             Rails.logger.warn("Failed to fetch faivcon #{favicon.url}: #{e}\n#{e.backtrace}")
+            ""
           ensure
             file&.unlink
           end

GitHub sha: b9df7a22

2 Likes

Implicit return strikes again :bomb: