FIX: Make category-chooser show all parent categories (PR #8706)

Before:

Screen Shot 2020-01-13 at 15 04 40

After:

Screen Shot 2020-01-13 at 15 03 42

GitHub

You’ve signed the CLA, udan11. Thank you! This pull request is ready for review.

DeepCode’s analysis on #d6cfab found:

  • :x: 0 critical issues. :warning: 0 warnings and 0 minor issues. :heavy_check_mark: 0 issues were fixed.

:speech_balloon: This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


:relaxed: If you want to provide feedback on our bot, here is how to contact us.

    const parentCategoryId = category.parent_category_id;
        hideParent: !!category.parent_category_id,

Sounds reasonable, a lot of this code has changed in sk2, will have to keep it in mind, but should be good :+1:

Technically not needed :wink:

Can you add a way to prevent infinite recursion? Eg. probably based on the site setting?

@udan11 can you merge this today please ? I need to apply this to select-kit 2 for clean merge

1 Like

Bump @udan11