FIX: Mobile Safari composer improvements (PR #8069)

This includes two fixes:

  • prevents keyboard from being invoked when textarea is disabled (this happens when a category selection is required when creating a new topic)
  • avoids scrolling up when switching focus from title to textarea on new topic creation

See below videos for an illustration of the second fix.

Before: https://monosnap.com/file/3ohWIJB8TcqvUYqnkypuBZVzq1tG2C

After: https://monosnap.com/file/HngAVObO5gy3XUTnYP7mNDITC504zQ

GitHub

You’ve signed the CLA, pmusaraj. Thank you! This pull request is ready for review.

Sure this seems like a safe hack to add to safari hack mountain. I wonder if we are getting any closer to getting rid of this stuff with ios 13, I recall there are some new apis that let you get viewport in 13, this is now something we can lean on https://developer.mozilla.org/en-US/docs/Web/API/Visual_Viewport_API with 13

2 Likes

Oh my goooddd I can’t wait for iOS 13 to land for this reason alone. (New carplay is also very nice)

On Tue, Sep 3, 2019 at 11:04 PM Sam notifications@github.com wrote:

Merged #8069 https://github.com/discourse/discourse/pull/8069 into master.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/discourse/discourse/pull/8069?email_source=notifications&email_token=AALTWVOABCUUAZVNLLWYHOTQH5FWRA5CNFSM4ITKD4NKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTNITOMQ#event-2605791026, or mute the thread https://github.com/notifications/unsubscribe-auth/AALTWVKTSFDVORXIJLJXFJLQH5FWRANCNFSM4ITKD4NA .

2 Likes