FIX: Notification menu broken on older browsers (#14019)

FIX: Notification menu broken on older browsers (#14019)

replaceAll is not available in all versions of Chrome/Firefox/Edge that we support, so we need to use replace instead

diff --git a/app/assets/javascripts/discourse/app/widgets/default-notification-item.js b/app/assets/javascripts/discourse/app/widgets/default-notification-item.js
index ff9d09f..d9ab91e 100644
--- a/app/assets/javascripts/discourse/app/widgets/default-notification-item.js
+++ b/app/assets/javascripts/discourse/app/widgets/default-notification-item.js
@@ -33,7 +33,7 @@ export const DefaultNotificationItem = createWidget(
       const lookup = this.site.get("notificationLookup");
       const notificationName = lookup[notificationType];
       if (notificationName) {
-        classNames.push(notificationName.replaceAll("_", "-"));
+        classNames.push(notificationName.replace(/_/g, "-"));
       }
       return classNames;
     },

GitHub sha: 814aa64a5d089d25f893c334714f2feac8d2a4ae

This commit appears in #14019 which was approved by tshenry. It was merged by martin.

This commit has been mentioned on Discourse Meta. There might be relevant details there: