FIX: phpbb import - attachments not embedded in posts (#14570)

FIX: phpbb import - attachments not embedded in posts (#14570)

diff --git a/script/import_scripts/phpbb3/support/text_processor.rb b/script/import_scripts/phpbb3/support/text_processor.rb
index b5b9d9a..f49765d 100644
--- a/script/import_scripts/phpbb3/support/text_processor.rb
+++ b/script/import_scripts/phpbb3/support/text_processor.rb
@@ -159,7 +159,7 @@ module ImportScripts::PhpBB3
       attachment_regexp = /\[attachment=([\d])+\]<!-- [\w]+ -->([^<]+)<!-- [\w]+ -->\[\/attachment\]?/i
       unreferenced_attachments = attachments.dup
 
-      text = text.gsub(attachment_regexp) do
+      text.gsub!(attachment_regexp) do
         index = $1.to_i
         real_filename = $2
         unreferenced_attachments[index] = nil

GitHub sha: 97178cd777b5745183b5edfb1ef3a2ef269dafcc

This commit appears in #14570 which was approved by gschlager. It was merged by gschlager.