FIX: Remove 'reply above line' marker (PR #13927)

This marker is automatically added by Discourse’s group SMTP mailer. When user responded to emails sent by it, Discourse did not trim this marker.

GitHub

What if the user has a different locale set than the server? Does this still work?

My thinking would be that the message string would be different and it might not match.

Yes, that is a limitation and unfortunately we have it for the “Previous Replies” marker too. I tried to find other ways of identifying those markers, but could not find any. The only thing that makes this a bit more special are the “##”, but that is not true for “Previous Replies” too and may be too sensitive.

Can we somehow get all the translations for this string and generate a regexp from that? (same for “previous_replies”)

I followed up in: