FIX: Remove xlink:href to favour href due to deprecation (#14854)

FIX: Remove xlink:href to favour href due to deprecation (#14854)

Based on docs here <use> - SVG: Scalable Vector Graphics | MDN, the xlink:href attribute is deprecated and we should probably move away from it soon.

diff --git a/app/assets/javascripts/pretty-text/engines/discourse-markdown/image-controls.js b/app/assets/javascripts/pretty-text/engines/discourse-markdown/image-controls.js
index ec438d5..6c49d5d 100644
--- a/app/assets/javascripts/pretty-text/engines/discourse-markdown/image-controls.js
+++ b/app/assets/javascripts/pretty-text/engines/discourse-markdown/image-controls.js
@@ -73,7 +73,7 @@ function buildImageAltTextButton(altText) {
   <span class="alt-text" aria-label="${I18n.t(
     "composer.image_alt_text.aria_label"
   )}">${altText}</span>
-  <span class="alt-text-edit-btn"><svg aria-hidden="true" class="fa d-icon d-icon-pencil svg-icon svg-string"><use xlink:href="#pencil-alt"></use></svg></span>
+  <span class="alt-text-edit-btn"><svg aria-hidden="true" class="fa d-icon d-icon-pencil svg-icon svg-string"><use href="#pencil-alt"></use></svg></span>
   <input class="alt-text-input" hidden="true" type="text" value="${altText}" />
 </span>
 `;
@@ -132,7 +132,7 @@ export function setup(helper) {
       "span.alt-text-readonly-container.alt-text",
       "span.alt-text-readonly-container.alt-text-edit-btn",
       "svg[class=fa d-icon d-icon-pencil svg-icon svg-string]",
-      "use[xlink:href=#pencil-alt]",
+      "use[href=#pencil-alt]",
       "input[type=text]",
       "input[hidden=true]",
       "input[class=alt-text-input]",

GitHub sha: 911f9b180a9060bcf72ab00c58394fedc1f16978

This commit appears in #14854 which was approved by techAPJ and tgxworld. It was merged by nattsw.