FIX: Rename all instances of bookmarkWithReminder to just bookmark (PR #9579)

  • Delete old bookmark code at the same time

IN PROGRESS: Please don’t review until I add a migration to fix the site settings for post menu

GitHub

We need to use manual SQL in migrations rather than Ruby objects.

Can you adjust this to update the value in the DB instead?

Argh sorry @eviltrout this is just an ingrained habit, I keep forgetting. Will change before merging.

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

This pull request has been mentioned on Discourse Meta. There might be relevant details there: