FIX: respect nofollow exclusion setting in topic featured links. (PR #11858)

Previously, nofollow attribute is not removed even when a domain is added to the exclude_rel_nofollow_domains site setting.

GitHub

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

We have to move away from Discourse.SiteSettings constant usage as it’s a global variable.

Instead could you pass in allowList as an option to this function? See this PR didn’t add this but the same approach should be done for User.currentProp - we could pass that in as an option externalLinksInNewTab: true when calling the function.

This is necessary for newer versions of Ember and to allow us to upgrade our application.

Good

Good

@vinothkannans can you try removing the Discourse.SiteSettings call this week so we can merge?