FIX: set missing count in redis even if zero

FIX: set missing count in redis even if zero

diff --git a/lib/s3_inventory.rb b/lib/s3_inventory.rb
index e43ab37..f6b053a 100644
--- a/lib/s3_inventory.rb
+++ b/lib/s3_inventory.rb
@@ -58,14 +58,14 @@ class S3Inventory
           missing_uploads = uploads.joins("LEFT JOIN #{table_name} ON #{table_name}.etag = #{model.table_name}.etag").where("#{table_name}.etag is NULL")
 
           if (missing_count = missing_uploads.count) > 0
-            $redis.set("missing_s3_#{model.table_name}", missing_count)
-
             missing_uploads.select(:id, :url).find_each do |upload|
               log upload.url
             end
 
             log "#{missing_count} of #{uploads.count} #{model.name.underscore.pluralize} are missing"
           end
+
+          $redis.set("missing_s3_#{model.table_name}", missing_count)
         ensure
           connection.exec("DROP TABLE #{table_name}") unless connection.nil?
         end

GitHub sha: 35431a8d

I think we were going to pull this out into some helper methods no?

1 Like

Yes we should. I hope this PR is okay for the helper method. I will add the spec test cases soon unless you need to change.

2 Likes