FIX: show edited site text overrides for non `_MF` keys (PR #8189)

This also fixes the expanding-text-.

this.value was being updated, but this.element.value was not, so the textarea was not actually expanding.

GitHub

You’ve signed the CLA, markvanlan. Thank you! This pull request is ready for review.

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

You can’t add the few key to pluralized strings in English. English uses only one and other.

1 Like

This looks good to me but I’d like @gschlager to review it.

I’m not a fan of testing private methods. The transform_pluralized_key method should just be an implementation detail. It would be better to test that upsert! works, otherwise it would be quite easy to break the functionality without us noticing.

1 Like

Yeah fair. I’ll do that.

This should use the other key. Usually it doesn’t matter, but other is the correct key to use. Sorry for nitpicking. :wink:

1 Like

Looks good! Feel free to merge after addressing my two comments.

I suggest using different values for one and other. That way your test can ensure that the interpolation keys from other are used.

1 Like

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/changing-systems-welcome-message/128572/18