At the moment, the “All outgoing email has been globally disabled by an administrator” banner doesn’t show to staff users if SiteSetting.disable_emails === “non-staff”. That means site admins might not realise emails are disabled until a user reports it.
You’ve signed the CLA, davidtaylorhq. Thank you! This pull request is ready for review.
ohh dear important oversight, thanks for this!
Can you also write a test for this?