FIX: small typo prevents icons from inheriting theme colors

FIX: small typo prevents icons from inheriting theme colors

The missing $ caused the fill color to be set to “primary” which is not a valid color. The variable $primary is the text color set in the theme.

From fcbfed3e62b65188538019eb5e510319a2f3e019 Mon Sep 17 00:00:00 2001
From: Joe <33972521+hnb-ku@users.noreply.github.com>
Date: Tue, 11 Dec 2018 12:49:20 +0800
Subject: [PATCH] FIX: small typo prevents icons from inheriting theme colors

The missing `$` caused the fill color to be set to "primary" which is not a valid color. The variable `$primary` is the text color set in the theme.

diff --git a/assets/stylesheets/checklist.scss b/assets/stylesheets/checklist.scss
index dd526be..6e2e0d1 100644
--- a/assets/stylesheets/checklist.scss
+++ b/assets/stylesheets/checklist.scss
@@ -5,7 +5,7 @@ span.chcklst-stroked {
 @mixin checklist-svg-icon($svg) {
   &:before {
     content: svg-uri(
-      '<svg aria-hidden="true" role="img" xmlns="http://www.w3.org/2000/svg" width="14px" height="16px" viewBox="0 0 448 512"><path fill="#{primary}" d="#{$svg}"></path></svg>'
+      '<svg aria-hidden="true" role="img" xmlns="http://www.w3.org/2000/svg" width="14px" height="16px" viewBox="0 0 448 512"><path fill="#{$primary}" d="#{$svg}"></path></svg>'
     );
   }
 }

GitHub

4 Likes