FIX: spec for oversized images security fix (PR #10671)

Spec to cover solution presented here - https://github.com/discourse/discourse/commit/333ddd40118bc5324c797d93f369669f6fd8e480

GitHub

No need to reset site settings in test because we use an in memory provider that is cleared after each test :slight_smile:

      expect(upload.persisted?).to eq(true)

Might be clearer this way.

I usually prefer to just use the translation so that changing the translation doesn’t break the spec.