FIX: Switch logos live when changing color schemes in user prefs (PR #13684)

GitHub

I think this element is originally rendered by the home-logo widget? Is modifying the DOM manually going to cause any weird side effects? e.g. if the header is re-rendered for some other reason, will this change be overridden?

I wonder if instead we should modify some central state (session.defaultColorSchemeIsDark, maybe?), and then make the header re-render whenever that property changes?

1 Like

Great point, I have updated the PR using an update to the central state. The second session state, darkModeAvailable, is needed when resetting the dark color scheme (i.e. choosing “Same as regular”).