FIX: Use safe navigation operator throughout statement

FIX: Use safe navigation operator throughout statement

From 4831c4c2eeef9124fd4bed6d63f26a8e55b6b9c9 Mon Sep 17 00:00:00 2001
From: David Taylor <david@taylorhq.com>
Date: Mon, 3 Dec 2018 20:00:28 +0000
Subject: [PATCH] FIX: Use safe navigation operator throughout statement


diff --git a/lib/validators/post_validator.rb b/lib/validators/post_validator.rb
index 0629b7c..9c1e7fe 100644
--- a/lib/validators/post_validator.rb
+++ b/lib/validators/post_validator.rb
@@ -146,7 +146,7 @@ class Validators::PostValidator < ActiveModel::Validator
     return if SiteSetting.max_consecutive_replies == 0 || post.id || post.acting_user&.staff? || private_message?(post)
 
     topic = post.topic
-    return if topic&.posts.first&.user == post.user
+    return if topic&.posts&.first&.user == post.user
 
     last_posts_count = DB.query_single(<<~SQL, topic_id: post.topic_id, user_id: post.acting_user.id, max_replies: SiteSetting.max_consecutive_replies).first
       SELECT COUNT(*)

GitHub

2 Likes