FIX: variable name typo in subcategory image

FIX: variable name typo in subcategory image

From ec26a59eac5a296e5e5c34e5f88b3242aa21f115 Mon Sep 17 00:00:00 2001
From: Vinoth Kannan <vinothkannan@vinkas.com>
Date: Wed, 5 Dec 2018 10:41:06 +0530
Subject: [PATCH] FIX: variable name typo in subcategory image


diff --git a/app/assets/javascripts/discourse/templates/components/categories-boxes.hbs b/app/assets/javascripts/discourse/templates/components/categories-boxes.hbs
index f133219..8635ee6 100644
--- a/app/assets/javascripts/discourse/templates/components/categories-boxes.hbs
+++ b/app/assets/javascripts/discourse/templates/components/categories-boxes.hbs
@@ -30,10 +30,10 @@
               <a class="subcategory" href={{sc.url}}>
                 <span class="subcategory-image-placeholder">
                   {{cdn-img
-                      src=c.uploaded_logo.url
+                      src=sc.uploaded_logo.url
                       class="logo"
-                      width=c.uploaded_logo.width
-                      height=c.uploaded_logo.height}}
+                      width=sc.uploaded_logo.width
+                      height=sc.uploaded_logo.height}}
                 </span>
                 <span class="subcategory-link">{{sc.name}}</span>
               </a>
diff --git a/app/assets/stylesheets/common/base/category-list.scss b/app/assets/stylesheets/common/base/category-list.scss
index 82d3556..8dcd5ab 100644
--- a/app/assets/stylesheets/common/base/category-list.scss
+++ b/app/assets/stylesheets/common/base/category-list.scss
@@ -143,7 +143,7 @@
         display: inline-block;
         margin-right: 0.6em;
       }
-      .logo {
+      .logo img {
         display: inline-block;
         height: 20px;
         width: 20px;

GitHub

1 Like

This commit has been mentioned on Discourse Meta. There might be relevant details there: