FIX: WebhookPostSerializer spec failure

FIX: WebhookPostSerializer spec failure

diff --git a/spec/serializers/web_hook_post_serializer_spec.rb b/spec/serializers/web_hook_post_serializer_spec.rb
index 2d56df3..eabc42b 100644
--- a/spec/serializers/web_hook_post_serializer_spec.rb
+++ b/spec/serializers/web_hook_post_serializer_spec.rb
@@ -10,7 +10,7 @@ RSpec.describe WebHookPostSerializer do
 
   it 'should only include the required keys' do
     count = serialized_for_user(admin).keys.count
-    difference = count - 34
+    difference = count - 35
 
     expect(difference).to eq(0), lambda {
       message = ""

GitHub sha: f7c4d8c8

Is the ignored attribute going to be useful in the context of a webhook? Since the Payload is always generated by an admin user, I think the attribute is not going to change. If the attribute, isn’t useful, we should exclude it from the webhook’s payload.

3 Likes

Good point! I think we can exclude it. Let me get to that :+1:

3 Likes