Font chooser (PR #10149)

I don’t follow the wizard js code so need some help. Guess we want to preview the fonts like the other steps.

GitHub

Is there a reason this is being done by manipulating themes? There are lots of edge cases with that (e.g. users changing the theme CSS, then re-running the wizard). For font size, we implemented the choice in core.

@davidtaylorhq Do you think it should be a site setting?

Yeah IMO that would be easier to maintain. Themes can still override fonts if they want to.

1 Like