Improve spam_hosts copy (PR #8203)

The domain included in the spam_hosts copy is confusing as it refers to a link the post that is being reviewed, not the link that caused all of the user’s posts with links to end up in the review queue. For now, it’s easiest to remove the link altogether and add a little more text to describe what the posts ended up in the review queue. For more context see: https://meta.discourse.org/t/white-listed-spam-host-domains-setting-not-being-honoured-for-new-users/130348

Changes include

  • Increase size of the reviewable’s conversation excerpt to prevent truncation of the new copy
  • Remove the domain parameter from the flag_linked_posts_as_spam method in the user model since it is no longer needed
  • Remove the domain interpolation variable from all translation files
  • Add “All posts from this user that include links should be reviewed.” to server.en.yml for added clarity on why the posts entered the queue

Result looks like:

Screen Shot 2019-10-16 at 11 06 24 AM

GitHub

You’ve signed the CLA, tshenry. Thank you! This pull request is ready for review.

This looks good to me. However, generally we only update English. Is there a problem if we update these @nlalonde ?

It’s not a problem, and I think you have to remove them in this case because they have an interpolation that won’t work anymore. Transifex will mark them as needing translation again, so they won’t be pulled back in until they’re updated by translators.