PERF: rate limit search, and add anon cache for search results (PR #9969)

GitHub

Just curious here - how slow are these tests? 30.times seems like a lot.

It was. I added a hidden site setting for this, and dialed the rate limits down in them so tests are much faster now

Looks good to me, merge at will.

1 Like
        before { sign_in(user) }
        before { sign_in(user) }

Hmm this is a little odd, we should just throw the error and let the rescue_from handler in ApplicationController handle it.

Ah is the intention for us to return the cached results if rate limit has been exceeded?

Oops sorry just read the thread on dev. This looks good to me.