PERF: Remove final N+1 from theme admin page

PERF: Remove final N+1 from theme admin page

The rails bug previously mentioned only causes an issue when using pluck, so this controller is not affected.

Followup to a8ffc02d06a12325f07f7cb7a8ff87119c3d3d0c

diff --git a/app/controllers/admin/themes_controller.rb b/app/controllers/admin/themes_controller.rb
index b491f16..b2d73a3 100644
--- a/app/controllers/admin/themes_controller.rb
+++ b/app/controllers/admin/themes_controller.rb
@@ -107,7 +107,7 @@ class Admin::ThemesController < Admin::AdminController
                                           :remote_theme,
                                           :theme_settings,
                                           :settings_field,
-                                          # :locale_fields, # Fails due to https://github.com/rails/rails/issues/34456
+                                          :locale_fields,
                                           :user,
                                           :color_scheme,
                                           theme_fields: :upload

GitHub sha: 35275c13

4 Likes