Prevent users from converting the default theme to a component (PR #11688)

GitHub

The title of this pull request changed from “Default theme” to "Prevent users from converting the default theme to a component

It looks like this line is repeated and you could move it out of the if

We need to NOT raise the error if no change needs to happen – so it would run if (param.to_s == "true") == (@theme.component?)

But as written above it doesn’t properly handle unspecified, so I put it inside both ifs.

I’m sorry, I’m late on this, but… I think it would be better to remove the “Convert” button for the default theme. It’s a very rare action, anyway.

@riking can you address @pmusaraj’s feedback and get this merged today?

Done