Redis 4 1 3 (PR #8204)

I couldn’t find a better way to make it work without freedom patch.

Problem is that the original Redis gem is removing :connector option (redis-rb/client.rb at master · redis/redis-rb · GitHub) We are passing that options around between retries and removing that on our end.

Our version of Connector got

def resolve(client = nil)
    ...
    options = @options.dup
    options.delete(:connector)
    client ||= Redis::Client.new(options)
    ...
    return loading ? @slave_options : @options

I checked on my local machine that with new freedom patch it is still working. Testing steps.

  1. run 2 instances of Redis with different ports
  2. stopped first Redis server
  • ensured that the site is still working
  • ensured we got periodic checks DiscourseRedis::FallbackHandler: Checking connection to master server...
  1. Started server again
  • ensured we got DiscourseRedis::FallbackHandler: Master server is active, killing all connections to slave...

GitHub

1 Like

You’ve signed the CLA, lis2. Thank you! This pull request is ready for review.

You’ve signed the CLA, lis2. Thank you! This pull request is ready for review.

You’ve signed the CLA, lis2. Thank you! This pull request is ready for review.

The title of this pull request changed from “Redis 4 1 3” to "WIP: Redis 4 1 3

The title of this pull request changed from “WIP: Redis 4 1 3” to "Redis 4 1 3