REFACTOR: Remove deprecated `action="something"` attributes (PR #10777)

In newer versions of Ember, this.sendAction is deprecated:

https://deprecations.emberjs.com/v3.x/#toc_ember-component-send-action

This patch removes most of our current uses (via d-button) but also some other rogue this.sendAction calls too.

GitHub

this dosnt look related to actions ?

doesn’t look related to actions

my bad, while fixing the actions I found this overwritten CP so I fixed that too. I’ll split it out.

@jjaffeux fixed

    {{d-button
      action=(action "close")

Added a small formatting suggestion.

On another note, we should be gradually moving away from {{action}} helper. See: https://guides.emberjs.com/v3.21.0/upgrading/current-edition/action-on-and-fn/

yes agreed, I didn’t want to nitpick, but :sweat_smile:

Hope we can have auto formatting of templates soon.

On another note, we should be gradually moving away from {{action}} helper. See: https://guides.emberjs.com/v3.21.0/upgrading/current-edition/action-on-and-fn/

Also agreed, on this, I wonder if we shouldn’t do some priority list of things to upgrade before and after ember-cli move.

  • what can we do today?
  • what should we do today?
  • what should we do as soon as possible?
  • what can wait?

So far I’ve been focused on deprecations in the Ember 3.15 branch I’m running on Ember CLI. Right now we have very few which feels great!