REFACTOR: Remove `Discourse.SiteSettimgs` from @setting decorator

REFACTOR: Remove Discourse.SiteSettimgs from @setting decorator

diff --git a/app/assets/javascripts/discourse/app/lib/computed.js b/app/assets/javascripts/discourse/app/lib/computed.js
index b4a6d4e..51292ae 100644
--- a/app/assets/javascripts/discourse/app/lib/computed.js
+++ b/app/assets/javascripts/discourse/app/lib/computed.js
@@ -162,6 +162,6 @@ export function endWith() {
 **/
 export function setting(name) {
   return computed(function() {
-    return Discourse.SiteSettings[name];
+    return this.siteSettings[name];
   });
 }
diff --git a/test/javascripts/lib/computed-test.js b/test/javascripts/lib/computed-test.js
index 7d9f39c..60aee87 100644
--- a/test/javascripts/lib/computed-test.js
+++ b/test/javascripts/lib/computed-test.js
@@ -25,7 +25,8 @@ discourseModule("lib:computed", {
 });
 
 QUnit.test("setting", function(assert) {
-  var t = EmberObject.extend({
+  let t = EmberObject.extend({
+    siteSettings: this.siteSettings,
     vehicle: setting("vehicle"),
     missingProp: setting("madeUpThing")
   }).create();

GitHub sha: 939fae35

This commit appears in #10290 which was merged by eviltrout.