REFACTOR: Removes `Discourse.SiteSettings` constant from tests

REFACTOR: Removes Discourse.SiteSettings constant from tests

This does not work in the Ember CLI world.

diff --git a/app/assets/javascripts/discourse/tests/helpers/site-settings.js b/app/assets/javascripts/discourse/tests/helpers/site-settings.js
index 4d2242c..ba52f3f 100644
--- a/app/assets/javascripts/discourse/tests/helpers/site-settings.js
+++ b/app/assets/javascripts/discourse/tests/helpers/site-settings.js
@@ -101,7 +101,6 @@ const ORIGINAL_SETTINGS = {
 };
 
 let siteSettings = Object.assign({}, ORIGINAL_SETTINGS);
-Discourse.SiteSettings = siteSettings;
 
 export function currentSettings() {
   return siteSettings;
diff --git a/app/assets/javascripts/discourse/tests/test_helper.js b/app/assets/javascripts/discourse/tests/test_helper.js
index 28b646a..c4e1deb 100644
--- a/app/assets/javascripts/discourse/tests/test_helper.js
+++ b/app/assets/javascripts/discourse/tests/test_helper.js
@@ -45,8 +45,10 @@
 //= require jquery.magnific-popup.min.js
 
 let App = window.Discourse;
-let resetSettings = require("discourse/tests/helpers/site-settings")
-  .resetSettings;
+let {
+  resetSettings,
+  currentSettings,
+} = require("discourse/tests/helpers/site-settings");
 let createHelperContext = require("discourse-common/lib/helpers")
   .createHelperContext;
 
@@ -78,6 +80,7 @@ d.write(
 App.rootElement = "#ember-testing";
 App.setupForTesting();
 App.injectTestHelpers();
+App.SiteSettings = currentSettings();
 App.start();
 
 // disable logster error reporting

GitHub sha: 4dec7d85

This commit appears in #10824 which was approved by pmusaraj. It was merged by eviltrout.