REFACTOR: reworks all the search-advanced-options panel (PR #10661)

This commit includes the following changes:

  • prevents any mutation of external (to the component) values
  • get rid of observers
  • uses @action
  • minor UI tweaks
  • dropped the unecessary debounce
  • drops all the legacy code for badges/groups which is not being used
  • replaces user-selector by user-chooser and improves multi-select to not show search if maximum has been reached

Most importantly this refactor should fix multiple bugs due to _update() being called multiple times if searchTerm was empty and other various bugs where some changes in searchTerm was not applied to the sidebar.

GitHub

Unsure if it will cause problems, but discourse-solved and discourse-assign both add things to the advanced search UI. We should double check they still work ok after merging.

Unsure if it will cause problems, but discourse-solved and discourse-assign both add things to the advanced search UI. We should double check they still work ok after merging.

I checked assign already and it was working

1 Like

Looks good!