This removes the need for the notification menu to scroll at various browser heights. Instead a flex layout is used to shift overflowed items into a hidden column. This also means we no longer need to estimate the menu height using JS because it’s handled in CSS.
This pull request introduces 4 alerts when merging 9c637b2690db281abd686c14b9087d7ff5644278 into 8850f51fd0f220edcd9bd9e13e7dd7a02b5dc9af - view on LGTM.com
- 4 for Unused variable, import, function or class
This looks much cleaner, just a few minor comments.
It looks like with this refactor you don’t need
estimateItemLimit() at all.
Ideally, this would work without
hasMore() was being used in one place,
quick-access-profile.js, so I changed it to
hideBottomItems() set it to return
false here and have it return true in
This pull request introduces 1 alert when merging 3a9ec865b1be74cb13e5e54710f3b367cfb68ca8 into 09254410eabc232a664e96f6480a3b63eec4e2e0 - view on LGTM.com
- 1 for Useless assignment to local variable